chore: add .gitattributes to normalize line endings to LF - #631
Open
devorun wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repository ships no
.gitattributes, so on Windows (gitcore.autocrlf=true, the default) a fresh clone checks out text files with CRLF.pnpm testthen fails out of the box: theskill-syncdrift guard inpackages/agent-coreassertscontent.startsWith("---\nname: ..."), which isfalsewhen theSKILL.mdfiles are CRLF.Adding a standard
.gitattributesnormalizes text files to LF on checkout, so a Windows contributor's working tree matches what the tests (and the Linux CI) already expect.Change
.gitattributes—* text=auto eol=lfA single line.
git add --renormalize .stages nothing else (the index is already LF), so there is no mass line-ending churn. No.bat/.cmd/.ps1files exist that would need aeol=crlfexception, and no committed fixtures or snapshots depend on CRLF.Testing
pnpm --filter @sapiom/agent-core testfails twoskill-syncassertions (has a canonical source with the … trigger frontmatter).SKILL.mdfiles check out as LF andskill-syncpasses 7/7.